perf: find TokenTable index once#425
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #425 +/- ##
==========================================
- Coverage 70.65% 70.64% -0.02%
==========================================
Files 219 219
Lines 16967 16970 +3
==========================================
Hits 11988 11988
- Misses 4084 4086 +2
- Partials 895 896 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dkharms
added
the
performance
eguguchkin
requested review from
cheb0,
eguguchkin and
forshev
and removed request for
eguguchkin
forshev
approved these changes
May 18, 2026
cheb0
reviewed
May 18, 2026
dkharms
force-pushed
the
0-token-table-scan
branch
from
e27177b to
f162f85
Compare
cheb0
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TableLoader.Loadpreviously re-scanned all token blocks on every call to find the start of the token table. This commit extracts that scan intoadvanceToTable, guarded by async.Once, so the linear scan over token blocks happens at most once perTableLoaderinstance.If you have used LLM/AI assistance please provide model name and full prompt: